Modernization of SQLAlchemy 2.0, Enhanced Security and 100% Test Coverage#19
Merged
raynaldlao merged 8 commits intomasterfrom Mar 10, 2026
Merged
Modernization of SQLAlchemy 2.0, Enhanced Security and 100% Test Coverage#19raynaldlao merged 8 commits intomasterfrom
raynaldlao merged 8 commits intomasterfrom
Conversation
…onfig and reformat codebase
…alue and update the related tests
…ized role usage, optimized comment queries and cleaned up service interfaces
…ative by bringing the app/ directory to 100% test coverage, enforcing vertical formatting for consistency, tightening role-based permissions on article actions, optimizing comment tree loading to remove N+1 queries and improving overall type safety through refined hints and session role casting
… the Account role CheckConstraint dynamic through the Role enum and removing the legacy Base.query property. It also improves documentation with clearer module and service docstrings
…structure and maintainability. It also updates the implementation plan and walkthrough documentation to reflect these changes.
hlargitte
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request: Excellence Technique & Couverture 100%
📝 Description
Cette PR apporte une refonte majeure de la qualité du code, de la sécurité et de la structure des données. L'objectif était d'atteindre une couverture de tests de 100% tout en modernisant l'infrastructure vers les derniers standards SQLAlchemy 2.0.
🛠️ Changements Clés
🏗️ Modernisation & Modèles (SQLAlchemy 2.0)
Héritage Natif : Passage de declarative_base() à la classe native DeclarativeBase.
Typage Strict : Utilisation systématique de Mapped[] et mapped_column() pour toutes les colonnes.
Clarté Maximale : Explicitation de tous les paramètres SQL dans les modèles (name=, type_=, nullable=, etc.) pour les colonnes et les relations (argument=, back_populates=).
Contraintes Dynamiques : La CheckConstraint des rôles est désormais générée dynamiquement à partir de l'énumération Role.
🛡️ Sécurité & Logique Métier
Gestion des Rôles :
Décorateurs : Harmonisation des accès via roles_accepted et login_required.
DRY : Remplacement des chaînes de caractères "en dur" par les constantes de l'énumération Role dans tout le projet (code + tests).
⚡ Performance & Qualité
Optimisation SQL : Éradication des requêtes N+1 via l'utilisation de joinedload dans ArticleService et CommentService.
Qualité de Code :
Documentation complète via des Docstrings.
🧪 Tests & Couverture
Couverture : Passage à 100% de couverture sur l'ensemble du répertoire app/.
Volume : 73 tests unitaires et fonctionnels validant l'intégralité des branches logiques.
Factories : Mise à jour des factories pour utiliser les constantes Role.