Fix quicklinks search: treat "&" and multilingual "and" equivalents as the same token#425
Open
digitalby wants to merge 1 commit intoraycast:mainfrom
Open
Fix quicklinks search: treat "&" and multilingual "and" equivalents as the same token#425digitalby wants to merge 1 commit intoraycast:mainfrom
digitalby wants to merge 1 commit intoraycast:mainfrom
Conversation
… as the same token
Contributor
|
@digitalby is attempting to deploy a commit to the Raycast Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #424
Problem
The Quicklinks Explorer search uses
name.toLowerCase().includes(search.toLowerCase()). This means&and word equivalents likeand,und,oraz, etc. are unrelated strings. A user searchingb and hwill not find Search B&H, andb&hwon't either due to spacing.Solution
Add a
normalizeSearchhelper that splits on whitespace and maps any known "and" token to a canonical&before comparison. Both sides of every filter call are normalized the same way.Token-splitting is used instead of regex word boundaries because
\bdoes not work correctly with non-ASCII scripts (e.g. Cyrillicи).AND_TOKENSis a plainSetthat can be extended with more languages or typos without touching the comparison logic.Initial token coverage:
andadnundorazieиTesting
b and hnow matches Search B&Hb&hnow matches Search B&Hb und hnow matches Search B&H&or "and" tokens are unaffected