Skip to content

Remove koriym/param-reader dependency#36

Merged
koriym merged 3 commits into1.xfrom
remove-param-reader
Mar 3, 2026
Merged

Remove koriym/param-reader dependency#36
koriym merged 3 commits into1.xfrom
remove-param-reader

Conversation

@koriym
Copy link
Member

@koriym koriym commented Mar 2, 2026

Summary

  • Remove koriym/param-reader dependency (no longer needed after doctrine/annotations removal)
  • Replace ParamReaderInterface in SqlFinder with native ReflectionParameter::getAttributes()
  • Remove ParamReaderInterface binding from SqlQueryProviderModule

Test plan

  • composer tests (cs + sa + test) all pass
  • ✅ 32 tests, 60 assertions OK
  • ✅ PHPStan / Psalm: no errors

Summary by Sourcery

Remove the external parameter reader dependency and rely on PHP native attributes for SQL query discovery.

Enhancements:

  • Refactor SqlFinder to resolve Sql annotations via ReflectionParameter attributes instead of an external ParamReader service.

Build:

  • Remove koriym/param-reader from composer dependencies.

Chores:

  • Drop the ParamReaderInterface binding from SqlQueryProviderModule now that it is no longer used.

Summary by CodeRabbit

  • Chores
    • Removed koriym/param-reader dependency from the project.
    • Refactored annotation discovery mechanism to utilize PHP 8 attributes. Existing external behavior and error handling remain unchanged.

Replace ParamReaderInterface with native ReflectionParameter::getAttributes()
since doctrine/annotations has been removed and only PHP 8 attributes are supported.
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 2, 2026

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

Warning

Rate limit exceeded

@koriym has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 22 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e269007 and d78e4fb.

📒 Files selected for processing (3)
  • .github/workflows/continuous-integration.yml
  • .github/workflows/static-analysis.yml
  • CHANGELOG.md
📝 Walkthrough

Walkthrough

The changes migrate from ParamReaderInterface-based parameter annotation reading to PHP 8 attributes discovery. The koriym/param-reader dependency is removed, SqlFinder is refactored to use native PHP attributes for Sql annotation reading, and related dependency injection bindings are removed.

Changes

Cohort / File(s) Summary
Dependency Management
composer.json
Removed koriym/param-reader from the "require" section.
Annotation Discovery Refactoring
src/SqlFinder.php
Constructor signature updated to accept only SqlDir as a promoted readonly property; ParamReaderInterface dependency removed. Parameter annotation discovery migrated from ParamReaderInterface to PHP 8 attributes using getAttributes(Sql::class) method.
Dependency Injection Configuration
src/SqlQueryProviderModule.php
Removed ParamReaderInterface-to-ParamReader binding and corresponding import statements.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 No more readers, just attributes shine,
PHP 8 magic, clean and fine!
SqlFinder hops with promoted grace,
Dependencies vanish without a trace.
Attributes lead the way to SQL's place! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately and concisely summarizes the primary change: removing the koriym/param-reader dependency from the project.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-param-reader

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@koriym
Copy link
Member Author

koriym commented Mar 2, 2026

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@koriym
Copy link
Member Author

koriym commented Mar 3, 2026

@coderabbitai approve

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

✅ Actions performed

Comments resolved. Auto-approval is disabled; enable reviews.request_changes_workflow to approve automatically.

@koriym koriym merged commit 2be57e7 into 1.x Mar 3, 2026
25 checks passed
@koriym koriym deleted the remove-param-reader branch March 3, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant