Conversation
Replace ParamReaderInterface with native ReflectionParameter::getAttributes() since doctrine/annotations has been removed and only PHP 8 attributes are supported.
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe changes migrate from ParamReaderInterface-based parameter annotation reading to PHP 8 attributes discovery. The koriym/param-reader dependency is removed, SqlFinder is refactored to use native PHP attributes for Sql annotation reading, and related dependency injection bindings are removed. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai approve |
✅ Actions performedComments resolved. Auto-approval is disabled; enable |
Summary
koriym/param-readerdependency (no longer needed after doctrine/annotations removal)ParamReaderInterfaceinSqlFinderwith nativeReflectionParameter::getAttributes()ParamReaderInterfacebinding fromSqlQueryProviderModuleTest plan
composer tests(cs + sa + test) all passSummary by Sourcery
Remove the external parameter reader dependency and rely on PHP native attributes for SQL query discovery.
Enhancements:
Build:
Chores:
Summary by CodeRabbit
koriym/param-readerdependency from the project.