Fix normalise_args incorrectly handling bound classmethods#59
Merged
Fix normalise_args incorrectly handling bound classmethods#59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
normalise_argswould bind the first argument to theclsinspect.getfullargspecincludesclsinspec.argsfor classmethods,but when the factory is a bound method (accessed via
Class.classmethod),clsis already bound and does not consume a positional argument at calltime. This caused
normalise_argsto be off-by-one on reconstruction afterpickling: an arg that was already present in the positional tuple would be
"claimed" by
cls, shifting every subsequent parameter one slot forward.The final parameter would then fall off the end and, if it had a default,
get appended again — producing a key mismatch and a
TypeErrorat calltime (too many positional arguments).
Fix by stripping the first element of
spec.argswheninspect.ismethodreturns True (which covers both bound classmethods and bound instance
methods, but not plain functions or static methods).
Add three unit tests covering the classmethod case:
doc/source/changelog.rst.