Open
Conversation
Owner
Author
|
Still need to test against AWS, GCP, and Azure. Neon tests passed. Still building out OSUOSL vms for additional self-hosted testing. Thanks OSUOSL! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR expands query-health coverage in pgFirstAid with high-impact, actionable checks and adds pgTAP validation for each new check across both
pg_firstAid()andv_pgfirstaid.pg_stat_statements-based workload checks.pg_stat_statements Extension Missingcheck with setup guidance for self-hosted PostgreSQL, AWS RDS, GCP Cloud SQL, and Azure PostgreSQL.pgfirstaid_pg_stat_statements_checks()and wired it intopg_firstAid()+v_pgfirstaidso extension-dependent checks run only when available.testing/pgTAP/03_high_tests.sqlnow runs1..42.Type of Change
Related Issues
Testing
pgFirstAid.sqlview_pgFirstAid.sqlview_pgFirstAid_managed.sqltesting/pgTAP/03_high_tests.sqlplan to1..42pg_stat_statements Extension Missingcheckpg_stat_statementschecks (only required when extension is present)testing/pgTAP/00_setup.sqltesting/pgTAP/03_high_tests.sqltesting/pgTAP/99_teardown.sqlPostgreSQL Version Compatibility
Has this code been tested against the following PostgreSQL versions?
Testing notes:
Managed Database Platforms
Has this code been deployed and tested on the following platforms?
Platform-specific notes:
pg_stat_statementson:pg_stat_statementsis missing, pgFirstAid still runs and reports a clear action item.Additional Notes