Add wallet detail shortcuts#492
Conversation
Bounty ramimbo#427: app/templates/wallet_detail.html
Bounty ramimbo#427: tests/test_wallet_api.py
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds two navigation links to the wallet detail template: one to view the wallet's activity and another to access its JSON API representation. Test assertions verify both links render correctly with proper encoding. ChangesWallet Detail Links
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
GHX5T-SOL
left a comment
There was a problem hiding this comment.
Reviewed current head eea0aa2f2e0f654cb3a4c08a20b0de3575b91936 as a non-author reviewer.
I inspected the wallet-detail shortcut change in app/templates/wallet_detail.html and the coverage in tests/test_wallet_api.py. The added actions use existing public routes: /activity?q=<wallet> reuses accepted-work search for the wallet account, while /api/v1/wallets/<wallet> opens the existing public wallet JSON endpoint. Wallet addresses are normalized by app/wallets.py to mrwk1 plus lowercase hex, so the direct API href does not introduce path confusion, and the activity link applies URL encoding for the query string.
Validation:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_wallet_api.py::test_wallet_pages_expose_transfer_and_github_claim_flows -q-> 1 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_wallet_api.py -q-> 32 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest -q-> 414 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python scripts/docs_smoke.py-> docs smoke okuv run --extra dev ruff check tests/test_wallet_api.py-> passeduv run --extra dev ruff format --check tests/test_wallet_api.py-> already formatteduv run --extra dev python -m mypy app-> successgit diff --check origin/main...HEAD-> clean- diff Gitleaks scan over
origin/main..HEAD-> no leaks - GitHub CodeRabbit check -> success, no actionable comments
No blocker found.
|
Quick scope note for the CodeRabbit warning: I rechecked the current GitHub PR metadata for #492. The PR is based on
Total current diff: +4/-0. The "129 files / repository initialization" warning appears to be a stale or fork-initialization false positive, not the current PR diff. No code changes needed for that warning. |
Bounty #427
Summary:
Evidence:
/wallets/<address>pages already link transfer, GitHub linking, and the ledger account, but users still have to manually compose the wallet API URL or activity search/api/v1/wallets/<address>Verification:
Summary by CodeRabbit
New Features
Tests