Refs #406: Accept hash-prefixed activity searches#486
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds issue-reference search to activity filtering. A new helper function parses ChangesGitHub issue reference search in activity
Possibly related PRs
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: fc20348f-afe7-49c0-95d3-b1bc9211e576
📒 Files selected for processing (2)
app/serializers.pytests/test_activity.py
GHX5T-SOL
left a comment
There was a problem hiding this comment.
Reviewed PR #486 at current head a2743e39aff7bfa0bdbb5b7c7d5c207ea379008c.
I do not see a blocker. The patch keeps the activity search display value intact (#164) while allowing a GitHub-style issue reference to match the numeric bounty issue number or internal bounty id. The fallback remains the existing broad text search first, so ordinary account/repo/proof searches continue to work before the hash-reference path is considered.
Validation I ran:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_activity.py -q -> 3 passed
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_activity.py tests/test_serializers.py -q -> 8 passed
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest -q -> 414 passed
uv run --extra dev ruff check app/serializers.py tests/test_activity.py -> passed
uv run --extra dev ruff format --check app/serializers.py tests/test_activity.py -> 2 files already formatted
uv run --extra dev python -m mypy app -> success
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python scripts/docs_smoke.py -> docs smoke ok
git diff --check origin/main...HEAD -> clean
gitleaks detect --no-banner --redact --source . --log-opts origin/main..HEAD --exit-code 1 -> no leaks found
GitHub CI is successful and CodeRabbit reports no actionable comments.
GHX5T-SOL
left a comment
There was a problem hiding this comment.
Reviewed the updated head 720f1f168c1925df3f19c0c92ac0fb0e8784fd08.
I do not see a blocker. The new commit adds the negative coverage CodeRabbit asked for, so invalid hash queries such as #, #abc, and #123abc now assert the empty activity result shape while the earlier valid #<issue> behavior remains covered.
Validation on this head:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /home/kali/money/mergework/.venv/bin/python -m pytest tests/test_activity.py -q -> 3 passed
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /home/kali/money/mergework/.venv/bin/python -m pytest tests/test_activity.py tests/test_serializers.py -q -> 8 passed
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /home/kali/money/mergework/.venv/bin/python -m pytest -q -> 414 passed
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /home/kali/money/mergework/.venv/bin/python scripts/docs_smoke.py -> docs smoke ok
/home/kali/money/mergework/.venv/bin/python -m ruff check app/serializers.py tests/test_activity.py -> passed
/home/kali/money/mergework/.venv/bin/python -m ruff format --check app/serializers.py tests/test_activity.py -> 2 files already formatted
/home/kali/money/mergework/.venv/bin/python -m mypy app -> success
git diff --check upstream/main...HEAD -> clean
gitleaks detect --no-banner --redact --source . --log-opts upstream/main..HEAD --exit-code 1 -> no leaks found
GitHub CI is successful and CodeRabbit is successful/skipped on the current head.
Summary
#<number>as a GitHub-style issue/bounty reference.#164) while matching the numeric bounty issue or bounty id fields.Validation
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_activity.py -q-> 3 passed, including invalid hash queries#,#abc, and#123abcPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev ruff check tests/test_activity.py-> passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev ruff format --check tests/test_activity.py-> 1 file already formattedgit diff --check-> passedSummary by CodeRabbit
New Features
#prefix (e.g.,#164) to find work tied to a specific issue.Tests
#queries returning no results.Bug Fixes / UI
#query in the search input, a “Showing accepted work matching” message, and a “Clear” link when filtered.