Refs #406: Accept backticked bounty references#476
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated the bounty reference regular expression in the queue health analyzer to recognize backticks around issue numbers (e.g., ChangesBackticked bounty reference recognition
Possibly related PRs
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
GHX5T-SOL
left a comment
There was a problem hiding this comment.
Reviewed current head 07d39cb670c0557d4b754eb694804b92cccd869e.
No blocker found in this focused pass. The regex change is narrowly scoped to accepting optional backticks immediately around #<issue> after the existing bounty/ref/fix/close/claim prefixes, so existing plain references keep working while the common Markdown form is covered by regression tests.
Evidence checked:
- PR is open, non-draft, mergeable/CLEAN, and project CI is successful.
- CodeRabbit completed successfully with no actionable review comments.
gh pr diff --patchand the PR files API show onlyscripts/pr_queue_health.pyandtests/test_pr_queue_health.py.- Existing
/claim #310coverage remains in the focused suite. - New regression coverage verifies both a backticked
Refsreference and a backticked/claimreference produce no missing-bounty warning.
Validation:
uv run --extra dev python -m pytest tests/test_pr_queue_health.py -q-> 10 passed in 0.52suv run --extra dev python -m pytest -q-> 415 passed in 81.38suv run --extra dev python scripts/docs_smoke.py-> docs smoke okuv run --extra dev python -m mypy app scripts/pr_queue_health.py-> Success: no issues found in 31 source filesuv run --extra dev ruff check scripts/pr_queue_health.py tests/test_pr_queue_health.py-> All checks passed!uv run --extra dev ruff format --check scripts/pr_queue_health.py tests/test_pr_queue_health.py-> 2 files already formattedgit diff --check origin/main...HEAD-> cleangit diff origin/main...HEAD | gitleaks stdin --no-banner --redact --exit-code 1-> no leaks found
jtc268
left a comment
There was a problem hiding this comment.
Approved.
I reviewed head 07d39cb. The regex change stays scoped to optional backticks around the issue reference, and the tests cover both prose and /claim variants. Existing plain references remain covered in the same suite.
Validation I ran:
- tests/test_pr_queue_health.py: 10 passed
- full pytest: 415 passed
- ruff check scripts/pr_queue_health.py tests/test_pr_queue_health.py passed
- ruff format --check scripts/pr_queue_health.py tests/test_pr_queue_health.py: 2 files already formatted
- mypy app scripts/pr_queue_health.py passed
- docs smoke passed
- git diff --check origin/main...HEAD clean
Summary
pr_queue_healthto recognize Markdown inline-code bounty references such asRefs `#406`/claimcommand bodies with a focused regression testRefs #406.
Evidence
The current queue-health scanner recognizes
Refs #406and/claim #406, but it misses common Markdown inline-code variants such asRefs `#406`. That can incorrectly flag otherwise valid bounty PRs/comments as missing a bounty reference.Validation
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev python -m pytest tests/test_pr_queue_health.py -q->10 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev python -m pytest -q->415 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev ruff check scripts/pr_queue_health.py tests/test_pr_queue_health.py-> passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev ruff format --check scripts/pr_queue_health.py tests/test_pr_queue_health.py->2 files already formattedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev python -m mypy app scripts/pr_queue_health.py-> successgit diff --check-> cleanNote: pytest plugin autoload is disabled because this workstation has an unrelated ROS Humble pytest plugin on the global path.
Summary by CodeRabbit
#123), providing greater formatting flexibility when specifying bounty references in pull request titles and descriptions.