Skip to content

Service for setting a pose the robot will hold#678

Open
heuristicus wants to merge 5 commits into
rai-opensource:mainfrom
ori-goals:posed-stand-merged
Open

Service for setting a pose the robot will hold#678
heuristicus wants to merge 5 commits into
rai-opensource:mainfrom
ori-goals:posed-stand-merged

Conversation

@heuristicus
Copy link
Copy Markdown
Contributor

@heuristicus heuristicus commented Jun 9, 2025

Change Overview

Adds the /spot/posed_stand service which allows setting the body height and roll/pitch/yaw of the robot. The pose is unset when the robot starts walking. Could be merged into a single service with the set stand height service, but maybe good to have them separate.

Testing Done

Tested by sending poses close to joint limits of the robot. Sending a value above the joint limits is clamped to those limits.

@heuristicus heuristicus marked this pull request as ready for review June 9, 2025 16:17
Copy link
Copy Markdown
Collaborator

@mhidalgo-rai mhidalgo-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heuristicus how is this different from sending a stand robot command through the action interface? We have plenty of duplication across interfaces, would be good to motivate a service-based alternative.

@heuristicus
Copy link
Copy Markdown
Contributor Author

I'm still getting familiar with the ros2 driver, by action interface do you mean sending things through the robot_command? If that's what you mean, I feel like the user experience for setting up commands with that mechanism was pretty involved to use. For some more complex commands I think using the robot command stuff is ok, since it's not really reasonable to add all the hundreds of commands the robot can run. I think it's good to have some which are commonly used be accessible so people can try things out more easily.

There's already a service for body height, and this is an expansion of that which uses the existing arguments the wrapper's stand function. I'd argue that this is more or less a "basic" command that is useful to access without having to run it through the robot command service.

Copy link
Copy Markdown
Contributor

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this change, since it seems like this is a simple enough command!

@tcappellari-bdai
Copy link
Copy Markdown
Collaborator

ya im good with this. I'll merge it in once its rebased on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants