Fix build on mac#119
Open
dta-bdai wants to merge 2 commits into
Open
Conversation
dta-bdai
requested review from
alberthli,
bhung-bdai,
jbruedigam-bdai,
pculbertson and
slecleach
as code owners
bhung-bdai
reviewed
Apr 27, 2026
Collaborator
bhung-bdai
left a comment
bhung-bdai
left a comment
There was a problem hiding this comment.
Quick question. I also cannot tell if the build is working since I don't have a Mac.
| pybind11 = ">=2.11" | ||
| onnxruntime-cpp = "1.19.*" # pin to match starfish (1.22+ needs CXXABI_1.3.15 / GCC 14) | ||
| llvm-openmp = { version = ">=22.1.4,<23", channel = "conda-forge" } | ||
| onnxruntime = ">=1.24.2,<2" |
Collaborator
There was a problem hiding this comment.
Is there a potential issue with pinning this version to >= 1.24.2 and the C++ version to 1.19?
Collaborator
Author
There was a problem hiding this comment.
Good catch! I've removed the onnxruntime python req. Thanks!
TODO: we do need to relax the onnxruntime-cpp version in starfish.
bhung-bdai
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.