Docs refresh: cover automation, review board, tmux backend, GitLab fixes#238
Merged
dhilgaertner merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
Adds docs/automation.md as the canonical guide to the auto-flow lifecycle and the Settings → Automation tab. Architecture, troubleshooting, and CLI reference are updated for the tmux backend (#229), terminal renaming (#206), Ghostty surface recovery (#218), and GitLab nested-group slugs (#233). CHANGELOG backfills [Unreleased] grouped by theme. Per-file + per-PR audit posted as a comment on #235. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dgershman
approved these changes
May 2, 2026
Collaborator
dgershman
left a comment
There was a problem hiding this comment.
Code & Security Review
Critical Issues
None.
Security Review
Strengths:
- Docs-only PR — no executable code changes, so no new attack surface.
- No secrets, credentials, or internal URLs exposed in any of the documentation.
- Troubleshooting guidance correctly avoids embedding tokens or auth secrets (directs users to
gh auth status/glab auth statusinstead).
Concerns:
- None.
Code Quality
Verified:
- All 7 source file paths referenced in
docs/architecture.mdanddocs/automation.mdexist in the codebase (TmuxBackend.swift, TerminalRouter.swift, AutoRespondCoordinator.swift, AutomationSettingsView.swift, AppConfig.swift, AppDelegate.swift, IssueTracker.swift). - Referenced symbols confirmed:
SessionTerminal.backend,FeatureFlags.tmuxBackend,TerminalRouter.canSend,ConfigDefaults,AutoRespondSettings. - All 55 PR numbers in
CHANGELOG.mdcross-checked againstgit log main— every one resolves to a merged commit. - Cross-link anchors verified (e.g.,
architecture.md#terminal-backendsmaps to an actual## Terminal Backendsheading). crow rename-terminalCLI command confirmed present inTerminalCommands.swiftandAppDelegate.swift.
Minor nit (non-blocking):
docs/automation.md:39lists Opus 4.7 as a supported model for auto permission mode. As of the current Claude model family (4.6), Opus 4.7 doesn't exist yet. This may be forward-looking or a typo — worth a quick double-check, but not blocking since it documents an external Claude Code requirement rather than Crow logic.
Summary Table
| Priority | Issue |
|---|---|
| 🟢 Green | Opus 4.7 model reference in docs/automation.md:39 — verify or remove |
Recommendation: Approve. This is a thorough docs refresh covering ~100 PRs worth of features. File references, PR numbers, cross-links, and symbol names all check out against the current codebase. The single nit is cosmetic and non-blocking.
dgershman
approved these changes
May 4, 2026
Collaborator
dgershman
left a comment
There was a problem hiding this comment.
Code & Security Review
Critical Issues
None.
Security Review
Strengths:
- Documentation-only PR — no executable code changes, so no runtime security impact.
- No secrets, credentials, or internal URLs exposed in the docs.
- Troubleshooting guidance correctly avoids recommending overly-permissive auth scopes.
Concerns:
- None.
Code Quality
Minor issues:
docs/automation.md:39— Lists "Opus 4.7" as a supported model for auto-permission mode. This model doesn't exist yet (the latest is Opus 4.6). The source code atAutomationSettingsView.swift:79doesn't enumerate specific model names. Consider removing the model list or marking it as "current models supported by Claude Code auto mode" to avoid staleness.
Positive observations:
- All source file paths referenced in the new docs (
TerminalRouter.swift,TmuxBackend.swift,AutoRespondCoordinator.swift,AutomationSettingsView.swift,AppConfig.swift) verified to exist at the stated locations. - Cross-doc anchors (
architecture.md#terminal-backends) resolve correctly. - The new
docs/automation.mdis well-structured: lifecycle overview → per-toggle Settings reference → per-PR deep dives → "where it lives" table. Good layering for different reader intents. - CHANGELOG backfill is grouped thematically rather than chronologically — easier to scan.
- Troubleshooting additions are concrete and actionable (e.g., tmux version requirement,
glab repo viewverification step).
Summary Table
| Priority | Issue |
|---|---|
| 🟡 Yellow | docs/automation.md:39 references non-existent "Opus 4.7" model — minor factual inaccuracy |
| 🟢 Green | Consider adding a note that the model list may change and users should check Claude Code's own error message for current supported models |
Recommendation: Approve — this is a thorough, well-organized docs refresh that accurately reflects the codebase. The one yellow item (Opus 4.7 reference) is non-blocking and can be fixed in a follow-up or before merge at the author's discretion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #235
Summary
docs/automation.mdas the canonical guide to Settings → Automation and the full auto-flow lifecycle.docs/architecture.mdwith the dual Ghostty/tmux backend (Add tmux backend behind CROW_TMUX_BACKEND feature flag (#198) #229), the newTerminalRouterdispatch, the Settings tab split (Split automation toggles into dedicated Settings tab #228), and the Review Board surface (Add 'Move to Active' button on completed sessions #188, Reconcile PR links for sessions missing reactive detection #205, Filter projects from review board via exclude list #207, Add bulk delete for sessions in the sidebar #210, Add multi-select and batch Start Review to Review Board #212, Add filtering for tickets list #220, Per-section select all and icon-only cancel button #226, Add quick action buttons to session detail header #231).crow rename-terminal(Add ability to rename terminals #206) todocs/cli-reference.md.GITLAB_HOSTsilent skip (Fix GitLab fetch failing on GITLAB_HOST mismatch #215), auto-respond not firing, and the silent no-ophook-eventbehavior (Silently skip hook-event when Crow app is not running #234).CROW_TMUX_BACKENDandCROW_HOOK_DEBUGto thedocs/configuration.mdenv-var table.CHANGELOG.md[Unreleased]with every PR from Add session analytics via Claude Code OpenTelemetry #137 through Silently skip hook-event when Crow app is not running #234, grouped by theme.README.mdfeatures list and docs index for the new automation suite, review board, terminal renaming, and tmux opt-in.docs/terminal-runtime-research.mdnoting Add tmux backend behind CROW_TMUX_BACKEND feature flag (#198) #229 shipped the headless-PTY backend recommended in the original research.The audit checklist called out as deliverable #1 in the issue is posted as a comment on #235.
Test plan
git diff --stat mainshows only the listeddocs/,CHANGELOG.md, andREADME.mdfilescrow --helpmatches the command list indocs/cli-reference.md(onlyrename-terminalwas missing pre-PR)git log --since=2026-04-15 main --onelineand confirm each one resolvesdocs/crow-screenshot.jpegagainst the current Settings/Review-Board UI — deferred to a follow-up, called out in the audit comment🤖 Generated with Claude Code