Codex-generated pull request#42
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6741efae77
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| async function runAnalyzeFromPreprocessed(result, fallbackQuestion = '') { | ||
| const body = { | ||
| input_type: result.input_type || 'csv', |
There was a problem hiding this comment.
In runAnalyzeFromPreprocessed, the request keeps input_type: result.input_type, so preprocessed Excel/Document jobs are sent to /api/analyze as excel/document without file_base64. The server’s analyze handler (bitnet_tools/web.py, /api/analyze branch) re-enters raw-file preprocessing for those input types, which raises on empty file_base64, so Excel/Document analysis now fails after a successful preprocess job.
Useful? React with 👍 / 👎.
| setPreprocessStatusText(`job=${queued.job_id} status=${queued.status}`); | ||
| setStatus('입력 전처리 큐 등록 완료'); | ||
| await pollPreprocessJobOnce(); | ||
| startPreprocessPolling(); |
There was a problem hiding this comment.
startPreprocessAndAnalyze always calls startPreprocessPolling() after awaiting pollPreprocessJobOnce(). If that first poll already observes a terminal state (especially done for fast CSV preprocess jobs), the timer schedules one more poll and re-runs terminal handling; for done this triggers a second runAnalyzeFromPreprocessed call and duplicate /api/analyze work.
Useful? React with 👍 / 👎.
1 participant
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task