feat(ui): phase 1 quick/advanced UI, improved numeric parsing, and offline bundle tooling#32
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61dd77bb62
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| except ValueError: | ||
| return None | ||
|
|
||
| return -parsed if negative_by_parentheses else parsed |
There was a problem hiding this comment.
Avoid double-negating parenthesized values
When _to_float sees parentheses it always negates the parsed value, so an input like (-99.1) is normalized to -99.1 and then flipped to +99.1. This silently corrupts numeric summaries for datasets that already include an explicit minus sign inside parentheses (a common export quirk), because those rows are now treated as positive instead of negative.
Useful? React with 👍 / 👎.
Motivation
Description
bitnet_tools/ui/index.html,bitnet_tools/ui/app.js, andbitnet_tools/ui/styles.css, with advanced panels hidden by default.bitnet_tools.analysis._to_floatto normalize/remove commas, currency symbols, percent signs and interpret parentheses as negative values.scripts/prepare_online_bundle.sh,scripts/collect_online_assets.py,resources/online_sources.json, and documentation filesNEXT_STEPS_UI_AND_BACKLOG.md,BASELINE_PLAN.md,ONLINE_EXECUTION_LOG.md,ONLINE_RESOURCE_COLLECTION.md, andREVIEW_REPORT.md.tests/test_analysis.pyto validate the new numeric parsing and baseline summaries, and included UI smoke artifacts captured during validation.Testing
pytest -qand all tests passed (26 passed).Codex Task