Skip to content

feat: add baseline plan and normalize numeric parsing (phase 0-1)#28

Merged
rad1092 merged 1 commit into
mainfrom
codex/review-executable-rate-and-analysis-features
Feb 15, 2026
Merged

feat: add baseline plan and normalize numeric parsing (phase 0-1)#28
rad1092 merged 1 commit into
mainfrom
codex/review-executable-rate-and-analysis-features

Conversation

@rad1092
Copy link
Copy Markdown
Owner

@rad1092 rad1092 commented Feb 15, 2026

Motivation

  • Establish a repeatable baseline to compare pre/post changes for CSV analysis and lock representative fixtures for stable regression checks.
  • Improve numeric parsing so the analyzer correctly recognizes common human-entered numeric formats (thousands separators, currency symbols, percent signs, and negative-by-parentheses).
  • Add automated tests to validate numeric normalization and baseline fixture stability.

Description

  • Add BASELINE_PLAN.md to document the baseline criteria and operational steps for pre/post comparison.
  • Add three representative CSV fixtures under tests/fixtures/ (small_numeric.csv, mixed_formats.csv, missing_heavy.csv) to act as canonical inputs for baseline checks.
  • Update bitnet_tools/analysis.py _to_float to normalize ,, , $, , £, % and to handle negative values written in parentheses before attempting float() parsing.
  • Extend tests/test_analysis.py with test_to_float_normalizes_currency_comma_percent_parentheses and test_baseline_fixture_summaries_are_stable to assert normalization behavior and consistent summary outputs for the fixtures.

Testing

  • Ran pytest -q, all tests passed (26 passed).
  • Ran python -m bitnet_tools.cli doctor to validate environment diagnostics which executed successfully (reported local ollama absence).
  • Ran python -m bitnet_tools.cli --help to verify CLI usage output which executed successfully.

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a2bdc85b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bitnet_tools/analysis.py
Comment thread bitnet_tools/analysis.py
@rad1092 rad1092 merged commit 2967465 into main Feb 15, 2026
4 checks passed
@rad1092 rad1092 deleted the codex/review-executable-rate-and-analysis-features branch February 15, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant