Cloudfeeds customer access events#726
Conversation
when asked backward
"content" tag was not there
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 99.6% 99.57% -0.03%
==========================================
Files 79 80 +1
Lines 5564 5648 +84
Branches 784 795 +11
==========================================
+ Hits 5542 5624 +82
- Misses 10 11 +1
- Partials 12 13 +1
Continue to review full report at Codecov.
|
|
@glyph sorry I abandoned this :( |
|
@manishtomar No worries! It was closer to finished than I realized. Now we just have to wait 2 or 3 weeks for the Mac build to complete: https://www.traviscistatus.com/#metrics-display-graph-container-7cl94r33fvsg |
|
The one coverage issue here is that there needs to be a test for a |
|
If someone else would like to move this forward, it just needs test coverage. |
|
@glyph I'll get this done this week. |
|
@glyph I can't commit to this branch. Is it possible to give me permission for this repo temporarily? |
|
@manishtomar are you not doing this under your own fork? That would be the best way to do it. Otherwise @lekhajee will probably have to help you out. |
|
@manishtomar : Have added you as a collaborator. |
|
Thanks @lekhajee ! Now it's totally on you, @manishtomar :) |
|
@lekhajee It still shows me a "contributor" instead of "collaborator". interestingly it shows you also as "contributor". Can you please check again?
@BenjamenMeyer You are right. I should be doing that. It's just that I had committed to this branch and then left rackerlab repo. Now I've a very simple commit to finish the PR and was hoping to add it here instead of creating new PR from fork. |
Implement API to provide customer access events in cloud feeds format. This is based on https://one.rackspace.com/display/CUST/Access+Policy.