⚡ Bolt: [performance improvement] Optimize string conversions in checkUntrackedTodos#91
⚡ Bolt: [performance improvement] Optimize string conversions in checkUntrackedTodos#91
Conversation
Precompute .toLowerCase() for documents and hoist string methods out of N^2 loop inside cli/validators/todo-tracking.mjs Co-authored-by: raccioly <63126795+raccioly@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
content.toLowerCase()intoloadTrackingDocsto precompute the lowercased content once per file.todo.text.toLowerCase().trim()and string substring operations outside of thetrackingContent.some()loop insidecheckUntrackedTodos.🎯 Why:
Inside
checkUntrackedTodos,doc.content.toLowerCase()was repeatedly executed in the nested inner loop against every file, for every TODO item. Furthermore,todo.text.toLowerCase().trim()was also redundantly recalculated for every document. For codebases with many TODOs and large tracking docs, this formed a noticeable O(N*M) string allocation and parsing bottleneck.📊 Impact:
Reduces redundant string lowercasing and trimming operations from
(Todos * Docs) + (Todos * Docs)toTodos + Docs, significantly reducing memory allocation and improving the validator run time for large repositories.🔬 Measurement:
Run the CLI suite or manually execute
node cli/validators/todo-tracking.mjs(indirectly viaguard). The unit tests still pass viapnpm test.PR created automatically by Jules for task 17971078274132913942 started by @raccioly