Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Command Injection#89

Draft
raccioly wants to merge 1 commit intomainfrom
sentinel/fix-command-injection-1944622172690719633
Draft

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Command Injection#89
raccioly wants to merge 1 commit intomainfrom
sentinel/fix-command-injection-1944622172690719633

Conversation

@raccioly
Copy link
Copy Markdown
Owner

@raccioly raccioly commented May 6, 2026

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Command Injection (RCE) via execSync string interpolation in VS Code extension
🎯 Impact: Using user-controlled strings (such as the workspaceDir path) in execSync allows arbitrary shell command execution if the path contains shell metacharacters.
πŸ”§ Fix: Refactored execSpecguard and its call sites to pass argument arrays natively to execFileSync, avoiding internal string parsing and shell evaluation. Added .cmd fallbacks and Windows shell: true execution options specifically.
βœ… Verification: npm test passes and vscode-extension/extension.js is verified.


PR created automatically by Jules for task 1944622172690719633 started by @raccioly

Replaced `execSync` with `execFileSync` in `vscode-extension/extension.js` and updated command construction to pass argument arrays directly. This mitigates a high severity Remote Code Execution (RCE) vulnerability via string interpolation when parsing `workspaceDir`. Also handled cross-platform `.cmd` binary resolutions for Windows.

Co-authored-by: raccioly <63126795+raccioly@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant