π‘οΈ Sentinel: [CRITICAL] Fix Command Injection#89
Conversation
Replaced `execSync` with `execFileSync` in `vscode-extension/extension.js` and updated command construction to pass argument arrays directly. This mitigates a high severity Remote Code Execution (RCE) vulnerability via string interpolation when parsing `workspaceDir`. Also handled cross-platform `.cmd` binary resolutions for Windows. Co-authored-by: raccioly <63126795+raccioly@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command Injection (RCE) via
execSyncstring interpolation in VS Code extensionπ― Impact: Using user-controlled strings (such as the
workspaceDirpath) inexecSyncallows arbitrary shell command execution if the path contains shell metacharacters.π§ Fix: Refactored
execSpecguardand its call sites to pass argument arrays natively toexecFileSync, avoiding internal string parsing and shell evaluation. Added.cmdfallbacks and Windowsshell: trueexecution options specifically.β Verification:
npm testpasses andvscode-extension/extension.jsis verified.PR created automatically by Jules for task 1944622172690719633 started by @raccioly