Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in VS Code extension#84

Draft
raccioly wants to merge 1 commit intomainfrom
sentinel-command-injection-fix-16202726504476685480
Draft

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in VS Code extension#84
raccioly wants to merge 1 commit intomainfrom
sentinel-command-injection-fix-16202726504476685480

Conversation

@raccioly
Copy link
Copy Markdown
Owner

@raccioly raccioly commented May 5, 2026

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Command injection vulnerability in vscode-extension/extension.js via the execSync function. The args variable, constructed from inputs within the extension context, was passed directly to a shell environment. If args or paths contained shell metacharacters, it could lead to arbitrary command execution on the host machine.
🎯 Impact: A malicious actor could exploit this vulnerability to execute arbitrary shell commands on a developer's machine using the VS Code extension.
πŸ”§ Fix: Replaced execSync with execFileSync and an explicit array of arguments. This bypasses shell execution and ensures arguments are treated safely as program inputs. Included cross-platform fallback logic to properly append .cmd for tools like npx on Windows. Refactored the activate function to handle async constraints since refreshScore() includes await.
βœ… Verification: Ran node -c to verify no syntax errors were introduced. Verified that the overall test suite using pnpm test successfully completed without new regressions.


PR created automatically by Jules for task 16202726504476685480 started by @raccioly

Co-authored-by: raccioly <63126795+raccioly@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant