Skip to content

Update versions and some cleanup#1045

Closed
sims1253 wants to merge 3 commits intor-lib:v2-branchfrom
sims1253:v2-branch
Closed

Update versions and some cleanup#1045
sims1253 wants to merge 3 commits intor-lib:v2-branchfrom
sims1253:v2-branch

Conversation

@sims1253
Copy link
Copy Markdown

No description provided.

Bring the fork forward with Node 24-compatible action runtimes, newer GitHub Action dependencies, and setup-r support for multiline extra repositories.
Finish the low-risk upstream carryover by updating the leftover workflow checkout pins, expanding setup-pandoc runner coverage, and adding basic package tests for the coverage fixture.
Bring the READMEs back in sync with the updated workflow versions, fix the setup-pandoc platform typo, and document setup-r's multiline extra-repositories input.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.61%. Comparing base (6f6e5bc) to head (704ca17).

Additional details and impacted files
@@            Coverage Diff             @@
##           v2-branch    #1045   +/-   ##
==========================================
  Coverage      84.61%   84.61%           
==========================================
  Files              3        3           
  Lines             13       13           
==========================================
  Hits              11       11           
  Misses             2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gaborcsardi
Copy link
Copy Markdown
Member

Thanks! We can't merge PRs like this, because it is impossible to review the transpiled TS/JS code.

@sims1253
Copy link
Copy Markdown
Author

Thanks! We can't merge PRs like this, because it is impossible to review the transpiled TS/JS code.

Makes sense. Would there be value in me submitting part of this again? I guess I could remove the transpiled js and a trusted maintainer adds it for example?

@gaborcsardi
Copy link
Copy Markdown
Member

Makes sense. Would there be value in me submitting part of this again? I guess I could remove the transpiled js and a trusted maintainer adds it for example?

Possibly, but in general I would prefer smaller pull requests, that do one thing each. E.g. update actions from GH in one PR, fix typos in another, etc.

In any case, I am going to get to this soon. Your current PR is still useful to double check that I haven't missed anything.

@remlapmot
Copy link
Copy Markdown
Contributor

I think I updated most/all things in #1014 - sorry that is pretty massive - I did send some of those separately previously but they didn't get reviewed. And then it was just easier for me to have all the changes on a single branch.

Anyway you have a second comparison if you do it yourself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants