Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ The format is a modified version of [Keep a Changelog](https://keepachangelog.co
- `Other` - for technical stuff.

## [Unreleased]
### Improved
- Added option to toggle subtitle rendering on black bars ([@Secozzi](https://github.com/Secozzi)) ([#134](https://github.com/quickdesh/Animiru/pull/134))

## [v0.19.4.0] - 2026-02-26
### Other
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import androidx.compose.runtime.remember
import eu.kanade.presentation.more.settings.Preference
import eu.kanade.presentation.more.settings.screen.SearchableSettings
import eu.kanade.tachiyomi.ui.player.settings.SubtitlePreferences
import tachiyomi.i18n.animiru.AMMR
import tachiyomi.i18n.aniyomi.AYMR
import tachiyomi.presentation.core.i18n.stringResource
import uy.kohesive.injekt.Injekt
Expand All @@ -26,6 +27,7 @@ object PlayerSettingsSubtitleScreen : SearchableSettings {
val langPref = subtitlePreferences.preferredSubLanguages()
val whitelist = subtitlePreferences.subtitleWhitelist()
val blacklist = subtitlePreferences.subtitleBlacklist()
val blackBars = subtitlePreferences.subtitleBlackBars()

return listOf(
Preference.PreferenceItem.EditTextInfoPreference(
Expand Down Expand Up @@ -79,6 +81,11 @@ object PlayerSettingsSubtitleScreen : SearchableSettings {
dialogSubtitle = stringResource(AYMR.strings.pref_player_subtitle_blacklist_info),
title = stringResource(AYMR.strings.pref_player_subtitle_blacklist),
),
Preference.PreferenceItem.SwitchPreference(
preference = blackBars,
title = stringResource(AMMR.strings.player_pref_subtitle_black_bars),
subtitle = stringResource(AMMR.strings.player_pref_subtitle_black_bars_summary),
),
)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ import eu.kanade.tachiyomi.ui.player.settings.AdvancedPlayerPreferences
import eu.kanade.tachiyomi.ui.player.settings.AudioPreferences
import eu.kanade.tachiyomi.ui.player.settings.GesturePreferences
import eu.kanade.tachiyomi.ui.player.settings.PlayerPreferences
import eu.kanade.tachiyomi.ui.player.settings.SubtitlePreferences
import eu.kanade.tachiyomi.ui.player.utils.ChapterUtils.Companion.getStringRes
import eu.kanade.tachiyomi.util.system.powerManager
import eu.kanade.tachiyomi.util.system.toShareIntent
Expand Down Expand Up @@ -121,6 +122,7 @@ class PlayerActivity : BaseActivity() {
private val playerPreferences: PlayerPreferences = Injekt.get()
private val audioPreferences: AudioPreferences = Injekt.get()
private val advancedPlayerPreferences: AdvancedPlayerPreferences = Injekt.get()
private val subtitlePreferences: SubtitlePreferences = Injekt.get()
private val storageManager: StorageManager = Injekt.get()

// AM (DISCORD_RPC) -->
Expand Down Expand Up @@ -466,8 +468,9 @@ class PlayerActivity : BaseActivity() {
copyAssets(mpvDir)
copyFontsDirectory(mpvDir)

mpv.setOptionString("sub-ass-force-margins", "yes")
mpv.setOptionString("sub-use-margins", "yes")
val showBlackBars = if (subtitlePreferences.subtitleBlackBars().get()) "yes" else "no"
mpv.setOptionString("sub-ass-force-margins", showBlackBars)
mpv.setOptionString("sub-use-margins", showBlackBars)
mpv.addLogObserver(playerObserver)
mpv.addObserver(playerObserver)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class SubtitlePreferences(
fun preferredSubLanguages() = preferenceStore.getString("pref_subtitle_lang", "")
fun subtitleWhitelist() = preferenceStore.getString("pref_subtitle_whitelist", "")
fun subtitleBlacklist() = preferenceStore.getString("pref_subtitle_blacklist", "")
fun subtitleBlackBars() = preferenceStore.getBoolean("pref_subtitle_black_bars", false)

// Non-preferences

Expand Down
4 changes: 4 additions & 0 deletions i18n-animiru/src/commonMain/moko-resources/base/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@
<!-- Player prefs - internal player -->
<string name="player_pref_switch_on_failure">Switch video on loading failure</string>

<!-- Player prefs - subtitles -->
<string name="player_pref_subtitle_black_bars">Render on black bars</string>
<string name="player_pref_subtitle_black_bars_summary">Display subtitles on black bars when available</string>

<!-- Player - deband -->
<string name="player_sheets_video_settings_title">Video settings</string>
<string name="player_sheets_deband_title">Deband</string>
Expand Down
Loading