made es optional and log to local system#90
Open
Balatripura587 wants to merge 7 commits into
Open
Conversation
Signed-off-by: Bala Tripura Kumari Bodapati <bbodapat@redhat.com>
Signed-off-by: Bala Tripura Kumari Bodapati <bbodapat@redhat.com>
Signed-off-by: Bala Tripura Kumari Bodapati <bbodapat@redhat.com>
| imagePullPolicy: Always | ||
| volumes: | ||
| - name: test-results | ||
| emptyDir: {} |
Collaborator
There was a problem hiding this comment.
This will disappear with the pod. Looks like we might need a PVC based approach, but something that doesn't pre-allocate the memory, instead just on demand (.i.e maybe NFS?). And then a cp can be done on this.
Contributor
Author
There was a problem hiding this comment.
- I have identified an issue with current approach. Worker pods are mounted the same PVC directly — this worked because all pods anded on the same node, but breaks at scale when pods land on different nodes since they can't write to same PVC. So modified the approach where worker pods push per-image results to Redis , and the orchestrator collects all results from Redis after jobs finish and writes the aggregated JSON to its local volume.
- For PVC based approach,I think PVC would be better as NFS would require deploying and maintaining a separate NFS server. So I think this approach might be better. let me know your thoughts
| '%s_pull_results.json' % env_config["test_uuid"]) | ||
|
|
||
| # Write results to Elasticsearch (if configured) | ||
| if env_config["es_host"] and Elasticsearch: |
Collaborator
There was a problem hiding this comment.
We have a similar block above as well. Do you think this can be modularized and reused?
Signed-off-by: Bala Tripura Kumari Bodapati <bbodapat@redhat.com>
Signed-off-by: Bala Tripura Kumari Bodapati <bbodapat@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ES server configuration is made optional and when ES is not configured, all per-image push/pull results (with summary stats) and Vegeta timeseries data are written to local JSON files on a PVC.