PR consisting of frame interval and compose resolution fixes#72
Merged
vgarodia merged 2 commits intoqualcomm-linux:video.qclinux.mainfrom Mar 6, 2026
Merged
Conversation
The FRAME_RATE.max value in the platform data is stored in Q16 format. The frame interval reporting logic was using this scaled value directly, resulting in incorrect denominators being exposed to userspace. Convert the stored frame rate to its integer form before filling the stepwise min/step denominators. This restores correct frame interval reporting. Change-Id: I8945c24159d2be81c61743aa1f0a99c0a1d3a832 Signed-off-by: Venkata Siva Pavan KumarVenkatapatigari <venvenk@qti.qualcomm.com>
Initialize compose selection values to match crop values on hardware without scaling support (e.g., IRIS2/IRIS3) to prevent GStreamer decoder pipeline failures. GStreamer was receiving zero-valued compose rectangles, which violated V4L2 selection semantics and caused pipeline setup to fail. For hardware without scaling capability, compose and crop must be identical: - V4L2_SEL_TGT_COMPOSE_DEFAULT should equal V4L2_SEL_TGT_CROP - V4L2_SEL_TGT_COMPOSE defaults to V4L2_SEL_TGT_COMPOSE_DEFAULT This patch sets compose = crop: 1. During instance initialization (default resolution) 2. After stream parsing (firmware‑reported visible resolution) IRIS variants with scaling support are unaffected. Change-Id: Ibcc62405b583e8ca5ae6ebf68eb10ecea34c1b64 Signed-off-by: Venkata Siva Pavan KumarVenkatapatigari <venvenk@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tag brings a following updates for video driver to fix GST pipeline issues:
fix FRMIVAL stepwise denominators
Initialize compose selection values for decoder