Fix incorrect unit display names: preserve hyphens and fix whitespace normalization#15
Draft
Fix incorrect unit display names: preserve hyphens and fix whitespace normalization#15
Conversation
…tion in Sanitize Co-authored-by: jakubsemerak <3141116+jakubsemerak@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Analyze and fix bugs in generated units
Fix incorrect unit display names: preserve hyphens and fix whitespace normalization
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the unit name processing pipeline were producing incorrect display names in the generated C# units (e.g.,
"kilogramforce"instead of"kilogram-force","volt ampere"instead of"volt - ampere").Bug 1 —
normalize_unit_nameincorrectly stripped hyphens (normalizer.py)The method removed all
-characters from unit names, citing pint parsing issues. Unit names are never passed to pint (onlysymbolandconversion_factorare), so the stripping only corrupted display values.Affected names include
kilogram-force,pound-force,milli-inch,volt - ampere, and ~30 others. Names like"volt - ampere"additionally produced double spaces ("volt ampere") since the surrounding spaces were left behind after-removal.Bug 2 —
Sanitizediscarded whitespace normalization result (Generator.cs)The regex replace result was never assigned back, leaving multi-whitespace sequences intact in generated C# string literals.
Impact
parsedUneceUnits.jsonregenerated with correct namesKilogramForceinstead ofKilogramforce) andNamevalues match the UNECE standard✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.