Open
Conversation
warsky007
reviewed
Jan 28, 2022
| @@ -0,0 +1,6 @@ | |||
| package com.qiniu.pandora.collect.runner.model; | |||
|
|
|||
| public class MetaData { | |||
Collaborator
There was a problem hiding this comment.
我觉得MetaData定义成String比较好
configure的时候可以通过source.metaData="xxx"传递给source,然后由source进行解析,我们再提供一个接口供客户持久化metaData,入参还是个string,至于持久化的方式客户是不关心的。
也就是说我们不关心metaData是什么格式,也不去处理metaData,完全由source来处理
当前的方案我觉得我们要做的事情有点多
0a12cd4 to
74c52ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PDR-XXX
Changes
Reviewers
Checklist