Add missing AttentionSinkRopeRunner source to Android CMake build#17621
Add missing AttentionSinkRopeRunner source to Android CMake build#17621infil00p wants to merge 1 commit intopytorch:mainfrom
Conversation
attention_sink_rope_runner.cpp was added in pytorch#17302 but not included in the Android CMakeLists.txt QNN runner source list, causing linker errors when building the Android AAR with QNN support. Authored with Claude Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17621
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit 75b69b8 with merge base 298311e ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
Hi @infil00p, could you check the CI failures and run the lint runner to address any issues? If it runs well, feel free to merge the approved PR. |
|
@infil00p pinging once again |
Summary
attention_sink_rope_runner.cpp was added in #17302 but not included in the Android CMakeLists.txt QNN runner source list, causing linker errors when building the Android AAR with QNN support.
Authored with Claude
Test plan
This is a build issue, so the build should already be failing?
cc @kirklandsign @cbilgin @cccclai