Skip to content

Add missing AttentionSinkRopeRunner source to Android CMake build#17621

Open
infil00p wants to merge 1 commit intopytorch:mainfrom
baseweight:fix-qnn-cmake-missing-source
Open

Add missing AttentionSinkRopeRunner source to Android CMake build#17621
infil00p wants to merge 1 commit intopytorch:mainfrom
baseweight:fix-qnn-cmake-missing-source

Conversation

@infil00p
Copy link
Copy Markdown

@infil00p infil00p commented Feb 23, 2026

Summary

attention_sink_rope_runner.cpp was added in #17302 but not included in the Android CMakeLists.txt QNN runner source list, causing linker errors when building the Android AAR with QNN support.

Authored with Claude

Test plan

This is a build issue, so the build should already be failing?

cc @kirklandsign @cbilgin @cccclai

attention_sink_rope_runner.cpp was added in pytorch#17302 but not included in
the Android CMakeLists.txt QNN runner source list, causing linker
errors when building the Android AAR with QNN support.

Authored with Claude

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 23, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17621

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit 75b69b8 with merge base 298311e (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 23, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@nil-is-all nil-is-all added module: extension Issues related to code under extension/ module: android Issues related to Android code, build, and execution module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/ labels Feb 23, 2026
@mergennachin mergennachin requested a review from psiddh February 23, 2026 17:27
@nil-is-all
Copy link
Copy Markdown
Contributor

Hi @infil00p, could you check the CI failures and run the lint runner to address any issues? If it runs well, feel free to merge the approved PR.

@nil-is-all
Copy link
Copy Markdown
Contributor

Hi @infil00p, could you check the CI failures and run the lint runner to address any issues? If it runs well, feel free to merge the approved PR.

@infil00p any update?

@nil-is-all
Copy link
Copy Markdown
Contributor

@infil00p pinging once again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: android Issues related to Android code, build, and execution module: extension Issues related to code under extension/ module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants