Make NXP batch norm tests runnable in BUCK#17597
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17597
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 Cancelled JobAs of commit 14cee96 with merge base 746db5f ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93880277. |
This PR needs a
|
Summary: Make the NXP test_batch_norm_fusion tests compatible with the BUCK build system. The tflite import in executors.py is made optional since tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite. Differential Revision: D93880277
0407ea9 to
1622d2b
Compare
Summary: Make the NXP test_batch_norm_fusion tests compatible with the BUCK build system. The tflite import in executors.py is made optional since tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite. Differential Revision: D93880277
Summary: Pull Request resolved: pytorch#17597 Make the NXP test_batch_norm_fusion tests compatible with the BUCK build system. The tflite import in executors.py is made optional since tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite. Differential Revision: D93880277
1622d2b to
076e229
Compare
076e229 to
fb89b6d
Compare
Summary: Make the NXP test_batch_norm_fusion tests compatible with the BUCK build system. The tflite import in executors.py is made optional since tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite. Differential Revision: D93880277
fb89b6d to
548fab4
Compare
Summary: Pull Request resolved: pytorch#17597 Make the NXP test_batch_norm_fusion tests compatible with the BUCK build system. The tflite import in executors.py is made optional since tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite. Differential Revision: D93880277
Summary: Make the NXP test_batch_norm_fusion tests compatible with the BUCK build system. The tflite import in executors.py is made optional since tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite. Differential Revision: D93880277
548fab4 to
d810d3b
Compare
| # This source code is licensed under the BSD-style license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
|
|
||
| from __future__ import annotations |
There was a problem hiding this comment.
This import is never used. Are you internally using Python <3.10 and need this for type annotations (such as | (union))? Or what is the purpose of this?
Edit: Now I see it is required for the type hint:
class TFLiteExecutor:
_interpreter: tflite.Interpreter
MartinPavella
left a comment
There was a problem hiding this comment.
I assume the first commit is just a dependency, and only the second commit is meant for review in this PR. Perhaps it would be useful to state that explicitly. Otherwise, LGTM
Summary: Make the NXP test_batch_norm_fusion tests compatible with the BUCK build system. The tflite import in executors.py is made optional since tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite. Differential Revision: D93880277
d810d3b to
14cee96
Compare
Yes, just a dependency but not strictly needed, rebased so it is clear only one commit here and merging. |
Summary: Make the NXP test_batch_norm_fusion tests compatible with the BUCK build system. The tflite import in executors.py is made optional since tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite. Differential Revision: D93880277
Summary: Make the NXP test_batch_norm_fusion tests compatible with the BUCK build system. The tflite import in executors.py is made optional since tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite. Differential Revision: D93880277
Summary:
Make the NXP test_batch_norm_fusion tests compatible with the BUCK build
system. The tflite import in executors.py is made optional since
tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite.
Differential Revision: D93880277