Skip to content

Make NXP batch norm tests runnable in BUCK#17597

Merged
JakeStevens merged 1 commit intopytorch:mainfrom
JakeStevens:export-D93880277
Feb 24, 2026
Merged

Make NXP batch norm tests runnable in BUCK#17597
JakeStevens merged 1 commit intopytorch:mainfrom
JakeStevens:export-D93880277

Conversation

@JakeStevens
Copy link
Copy Markdown
Contributor

Summary:
Make the NXP test_batch_norm_fusion tests compatible with the BUCK build
system. The tflite import in executors.py is made optional since
tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite.

Differential Revision: D93880277

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 20, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17597

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Cancelled Job

As of commit 14cee96 with merge base 746db5f (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Feb 20, 2026

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93880277.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Feb 20, 2026
Summary:

Make the NXP test_batch_norm_fusion tests compatible with the BUCK build
system. The tflite import in executors.py is made optional since
tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite.

Differential Revision: D93880277
JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Feb 23, 2026
Summary:

Make the NXP test_batch_norm_fusion tests compatible with the BUCK build
system. The tflite import in executors.py is made optional since
tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite.

Differential Revision: D93880277
JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Feb 23, 2026
Summary:
Pull Request resolved: pytorch#17597

Make the NXP test_batch_norm_fusion tests compatible with the BUCK build
system. The tflite import in executors.py is made optional since
tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite.

Differential Revision: D93880277
JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Feb 24, 2026
Summary:

Make the NXP test_batch_norm_fusion tests compatible with the BUCK build
system. The tflite import in executors.py is made optional since
tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite.

Differential Revision: D93880277
JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Feb 24, 2026
Summary:
Pull Request resolved: pytorch#17597

Make the NXP test_batch_norm_fusion tests compatible with the BUCK build
system. The tflite import in executors.py is made optional since
tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite.

Differential Revision: D93880277
JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Feb 24, 2026
Summary:

Make the NXP test_batch_norm_fusion tests compatible with the BUCK build
system. The tflite import in executors.py is made optional since
tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite.

Differential Revision: D93880277
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.

from __future__ import annotations
Copy link
Copy Markdown
Collaborator

@MartinPavella MartinPavella Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is never used. Are you internally using Python <3.10 and need this for type annotations (such as | (union))? Or what is the purpose of this?

Edit: Now I see it is required for the type hint:

class TFLiteExecutor:
    _interpreter: tflite.Interpreter

@MartinPavella MartinPavella self-requested a review February 24, 2026 08:15
Copy link
Copy Markdown
Collaborator

@MartinPavella MartinPavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the first commit is just a dependency, and only the second commit is meant for review in this PR. Perhaps it would be useful to state that explicitly. Otherwise, LGTM

Summary:

Make the NXP test_batch_norm_fusion tests compatible with the BUCK build
system. The tflite import in executors.py is made optional since
tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite.

Differential Revision: D93880277
@JakeStevens
Copy link
Copy Markdown
Contributor Author

I assume the first commit is just a dependency, and only the second commit is meant for review in this PR. Perhaps it would be useful to state that explicitly. Otherwise, LGTM

Yes, just a dependency but not strictly needed, rebased so it is clear only one commit here and merging.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Feb 24, 2026
Summary:

Make the NXP test_batch_norm_fusion tests compatible with the BUCK build
system. The tflite import in executors.py is made optional since
tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite.

Differential Revision: D93880277
JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Feb 24, 2026
Summary:

Make the NXP test_batch_norm_fusion tests compatible with the BUCK build
system. The tflite import in executors.py is made optional since
tensorflow/tflite_runtime are not available in the BUCK environment. The tests enabled do not rely on the functionality enabled by tflite.

Differential Revision: D93880277
@JakeStevens JakeStevens merged commit fb04850 into pytorch:main Feb 24, 2026
151 of 157 checks passed
@JakeStevens JakeStevens deleted the export-D93880277 branch February 24, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants