_osdc-deploy: add modules/ref inputs and dynamic-region aws-login action#635
Open
jeanschmidt wants to merge 1 commit into
Open
_osdc-deploy: add modules/ref inputs and dynamic-region aws-login action#635jeanschmidt wants to merge 1 commit into
jeanschmidt wants to merge 1 commit into
Conversation
This was referenced May 27, 2026
tofu plan — arc-cbr-production-uw1✅ Plan succeeded · commit Plan output |
tofu plan — arc-cbr-production✅ Plan succeeded · commit Plan output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Impact: OSDC reusable deploy workflow + GitHub composite action
Risk: medium
What
Introduces a new
./.github/actions/osdc-aws-logincomposite action thatderives the AWS region from
just region <cluster>and configures AWScredentials, then refactors
_osdc-deploy.ymlto use it. Adds two newinputs to
_osdc-deploy.yml:modules(comma-separated list for partialdeploys) and
ref(git ref to check out for the deploy).Why
_osdc-deploy.yml; futuremulti-region clusters and PR-validation flows need region resolved
dynamically per cluster.
affected modules from a specific commit SHA (e.g. a Renovate PR head).
How
osdc-aws-loginrunsjust region <cluster>andpasses the result to
aws-actions/configure-aws-credentials. Outputsthe resolved region for downstream steps that need it.
_osdc-deploy.ymlreplaces three inline configure-aws-credentialsblocks with the composite action.
modulesinput is plumbed through tojust deploy-module/deploy-baseso callers can scope a deploy to a subset of modules.
refinput is plumbed through toactions/checkoutso deploys cantarget any commit, defaulting to the workflow's own ref.
Changes
.github/actions/osdc-aws-login/action.yml: new composite action..github/workflows/_osdc-deploy.yml: new inputs + 3 login-call sitesrefactored to the composite.
Testing
_osdc-deploy.ymlagainst a staging cluster after merge toconfirm region resolution and module scoping work end-to-end.
Signed-off-by: Jean Schmidt contato@jschmidt.me