Fix pyserial read_all return type#15785
Closed
MapleQiAN wants to merge 1 commit into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
MapleQiAN
force-pushed
the
fix-pyserial-read-all-return
branch
from
50e97e5 to
eddf7be
Compare
Author
|
Closing this because #15620 is already open for the same pyserial read_all issue. I missed the duplicate PR before opening this one. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15619.
serial.serialutil.SerialBase.read_all()returnsbytes, notNone, so this narrows the stub return type and adds a test case covering the inferred type.Test:
PYTHONPATH=lib python tests/mypy_test.py stubs\pyserial