Skip to content

Comments

Fix django-allauth deprecation warnings#2943

Open
hugovk wants to merge 1 commit intopython:mainfrom
hugovk:fix-deprecation-warnings
Open

Fix django-allauth deprecation warnings#2943
hugovk wants to merge 1 commit intopython:mainfrom
hugovk:fix-deprecation-warnings

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Feb 24, 2026

Description

  • Fix django-allauth deprecation warnings shown during make serve, make test, and so on.

Before

make test
docker compose run --rm web ./manage.py test
[+] Creating 2/0
 ✔ Container pythondotorg-redis-1     Running                                                                            0.0s
 ✔ Container pythondotorg-postgres-1  Running                                                                            0.0s
Found 661 test(s).
Creating test database for alias 'default'...
System check identified some issues:

WARNINGS:
?: settings.ACCOUNT_AUTHENTICATION_METHOD is deprecated, use: settings.ACCOUNT_LOGIN_METHODS = {'username', 'email'}
?: settings.ACCOUNT_EMAIL_REQUIRED is deprecated, use: settings.ACCOUNT_SIGNUP_FIELDS = ['email*', 'username*', 'password1*', 'password2*']

System check identified 2 issues (0 silenced).
....................................................................

After

make test
docker compose run --rm web ./manage.py test
[+] Creating 2/0
 ✔ Container pythondotorg-redis-1     Running                                                                            0.0s
 ✔ Container pythondotorg-postgres-1  Running                                                                            0.0s
Found 661 test(s).
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
.......................................................

Copilot AI review requested due to automatic review settings February 24, 2026 12:33
@hugovk hugovk requested a review from JacobCoffee as a code owner February 24, 2026 12:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the django-allauth configuration to use the modern settings API, eliminating deprecation warnings that appeared during make serve and make test operations.

Changes:

  • Replaced deprecated ACCOUNT_AUTHENTICATION_METHOD with ACCOUNT_LOGIN_METHODS
  • Replaced deprecated ACCOUNT_EMAIL_REQUIRED with ACCOUNT_SIGNUP_FIELDS

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants