fix: ci and group pkg installs#2902
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 900d427654
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR adds defensive error handling for the optional django-debug-toolbar dependency in the URL configuration. The change guards against ModuleNotFoundError when DEBUG=True in settings but the debug toolbar package is not installed, which can occur in CI environments or when only core dependencies are installed.
Changes:
- Wrapped
debug_toolbarimport and URL pattern addition in try/except ImportError block
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobCoffee
force-pushed
the
fix/guard-debug-toolbar-import
branch
from
900d427 to
716b962
Compare
JacobCoffee
force-pushed
the
fix/guard-debug-toolbar-import
branch
from
716b962 to
96c7f4b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobCoffee
force-pushed
the
fix/guard-debug-toolbar-import
branch
from
96c7f4b to
543e4a4
Compare
Dev dependencies are defined under [dependency-groups] (PEP 735), not [project.optional-dependencies]. Use `pip install --group dev` instead of `pip install '.[dev]'` in CI and Dockerfile. Guard debug_toolbar imports in local.py and urls.py with scoped ModuleNotFoundError checks so missing transitive deps still surface. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JacobCoffee
force-pushed
the
fix/guard-debug-toolbar-import
branch
from
543e4a4 to
31c88ce
Compare
JacobCoffee
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| install \ | ||
| '.[dev]' | ||
| install --group dev \ | ||
| . |
The docs dependencies are in [dependency-groups], not [project.optional-dependencies], so pip install '.[docs]' fails. Use pip install --group docs to match the pattern from #2902. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The docs dependencies are in [dependency-groups], not [project.optional-dependencies], so pip install '.[docs]' fails. Use pip install --group docs to match the pattern from #2902. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
pip install --group dev(PEP 735) instead ofpip install '.[dev]'in CI and Dockerfile[dependency-groups], not[project.optional-dependencies]import debug_toolbarinurls.pyandlocal.pywith scopedModuleNotFoundErrorcheckdebug_toolbaritself is missing; re-raises transitive import failuresTest plan
make serveworks with Docker🤖 Generated with Claude Code