Avoid eager file read in State.parse_file() when using native parser#21516
Closed
JiwaniZakir wants to merge 1 commit into
Closed
Avoid eager file read in State.parse_file() when using native parser#21516JiwaniZakir wants to merge 1 commit into
JiwaniZakir wants to merge 1 commit into
Conversation
When there was only one file in a parse batch, State.parse_file() was called directly and invoked get_source() unconditionally, reading the file eagerly in Python. This is unnecessary for on-disk files with the native parser, which reads files itself in Rust. The fix skips get_source() in that case, matching the behavior of the parallel path. Fixes python#21514
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
State.parse_file()inmypy/build.py,get_source()was called unconditionally whenraw_datawasNone, causing eager file reading in Python even when using the native parser with a single on-disk file in the batch. The fix makesget_source()conditional, skipping it when the native parser is enabled, no source override is present, and the file exists on disk — passing an empty string toparse_file_inner()instead, matching the parallel code path. Runpython -m pytest mypy/test/testparse.py mypy/test/testfinegrained.py -x -qto verify.Fixes #21514