[mypyc] Fix crash on accessing StopAsyncIteration#21406
Merged
p-sawicki merged 8 commits intopython:masterfrom May 5, 2026
Merged
[mypyc] Fix crash on accessing StopAsyncIteration#21406p-sawicki merged 8 commits intopython:masterfrom
p-sawicki merged 8 commits intopython:masterfrom
Conversation
JukkaL
reviewed
May 5, 2026
|
|
||
|
|
||
| def load_address_op(name: str, type: RType, src: str) -> LoadAddressDescription: | ||
| def load_address_op( |
Collaborator
There was a problem hiding this comment.
Now the name doesn't quite match the intent -- it either loads the address or the value of the name. Instead of adding a bool flag to the control for address/value, I think it would be better to add a new dictionary for something like load_global_op(<fullname>, <type>, <c_name>). This way the pre-existing buildin_names dictionary wouldn't have to be touched at all, I think.
JukkaL
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
StopAsyncIterationinraiseexpressions or as the caught type inexceptblocks crashes at runtime because the generated code loads the address of thePyExc_StopAsyncIterationvariable and casts it toPyObject *. The variable itself is already aPyObject *so its address being interpreted asPyObject *is incorrect.To fix, add a special case to use
LoadGlobalinstead ofLoadAddressfor builtin type variables that are alreadyPyObject *.