[mypyc] Add str.isdigit() primitive#20893
Open
VaggelisD wants to merge 1 commit intopython:masterfrom
Open
Conversation
VaggelisD
commented
Feb 24, 2026
|
|
||
|
|
||
| bool CPyStr_IsDigit(PyObject *str) { | ||
| Py_ssize_t len = PyUnicode_GET_LENGTH(str); |
Contributor
Author
There was a problem hiding this comment.
There's a recurring pattern for these primitives, should we try to abstract their codegen?
Gave macros a shot for to hide the per-kind for loop, though we could go a step further and do the same for entire functions I guess.
0fd7932 to
819be52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar issue as the str.isalnum() PR, for large enough strings the primitive introduces a perf regression but is generally faster on common cases:
'0')'1234567890')'5' * 100)٠)'a')'a' * 100)'0' * 99 + 'a')