Fix loop convergence with redefinitions#20865
Merged
ilevkivskyi merged 4 commits intopython:masterfrom Feb 23, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Repro for meson difference: Currently we silently infer |
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Feb 23, 2026
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we reset the variable type each time we visit the initial definition (textually first assignment). This can cause problems with
--allow-redefinition-new:The only non-trivial part here is handling of this pattern:
It is special-cased in regular mode, and this special-casing used to work accidentally with redefinition allowed. Now I simply make the same special-casing apply (since for loops can never be runaway on index).