Do not repor trivial narrowing as a change in binder#20862
Open
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Open
Do not repor trivial narrowing as a change in binder#20862ilevkivskyi wants to merge 1 commit intopython:masterfrom
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20816
This makes
--allow-redefinition-new~10% faster (or maybe more if you have too many loops in your code). The idea is quite simple: there is no difference between no narrowing, and narrowing to type that is a variable declared type. This doesn't really make a difference for regular mode, IIUC because there is a "fall through", i.e. zero-iterations case, but this doesn't work withbind_all = True. As a result we used to accept every loop with an assignment in it at lest twice with--allow-redefinition-new(which includes assignment to iteration variable in for-loop).Note that
declaration_typemay beNoneif there is a partial type, but we already track partial types in accept loop separately, so we don't need to report them as changed here as well.