gh-87245: Improve IPv6Address.ipv4_mapped documentation#92572
Merged
ncoghlan merged 2 commits intopython:mainfrom May 4, 2026
Merged
gh-87245: Improve IPv6Address.ipv4_mapped documentation#92572ncoghlan merged 2 commits intopython:mainfrom
ncoghlan merged 2 commits intopython:mainfrom
Conversation
Avoid the phrasing ‘starting with ::FFFF/96’, which is confusing since it seems to mix a prefix and a range. Instead, make it clear what the actual range is, and refer to the relevant RFC. Closes python#87245.
Contributor
Author
|
(this can be labelled as |
MaxwellDupre
approved these changes
Jun 19, 2022
Contributor
MaxwellDupre
left a comment
MaxwellDupre
left a comment
There was a problem hiding this comment.
Checked all good. Even though RFC 4291 does not actually state precisely the address given.
|
This PR is stale because it has been open for 30 days with no activity. |
ncoghlan
approved these changes
May 4, 2026
ncoghlan
added
triaged
Contributor
|
A case of stale bot nudges doing their job - sorry for the long delay here, and thanks for the PR! |
Documentation build overview
|
|
GH-149360 is a backport of this pull request to the 3.14 branch. |
|
GH-149361 is a backport of this pull request to the 3.13 branch. |
ncoghlan
pushed a commit
that referenced
this pull request
May 4, 2026
) (#149361) gh-87245: Improve IPv6Address.ipv4_mapped documentation (GH-92572) Avoid the phrasing ‘starting with ::FFFF/96’, which is confusing since it seems to mix a prefix and a range. Instead, make it clear what the actual range is, and refer to the relevant RFC. Closes GH-87245. (cherry picked from commit 7aedd0a) Co-authored-by: wouter bolsterlee <wouter@bolsterl.ee>
ncoghlan
pushed a commit
that referenced
this pull request
May 4, 2026
) (#149360) gh-87245: Improve IPv6Address.ipv4_mapped documentation (GH-92572) Avoid the phrasing ‘starting with ::FFFF/96’, which is confusing since it seems to mix a prefix and a range. Instead, make it clear what the actual range is, and refer to the relevant RFC. Closes GH-87245. (cherry picked from commit 7aedd0a) Co-authored-by: wouter bolsterlee <wouter@bolsterl.ee>
|
while at it, you could do a quick s/FFFF/ffff/ to be compliant with rfc5952 §4.3 ,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid the phrasing ‘starting with ::FFFF/96’, which is confusing since
it seems to mix a prefix and a range. Instead, make it clear what the
actual range is, and refer to the relevant RFC.
Closes #87245.