gh-150116 Remove dead try/except in asyncio.Lock._wake_up_first#150117
Open
deadlovelll wants to merge 1 commit into
Open
gh-150116 Remove dead try/except in asyncio.Lock._wake_up_first#150117deadlovelll wants to merge 1 commit into
deadlovelll wants to merge 1 commit into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
Is it possible for another thread to add something to the container between the two checks? |
Author
Thanks for marking it. But asyncio primitives are not thread-safe. The official documentation says: link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncio.Lock._wake_up_firsthad atry/except StopIterationblock guardingnext(iter(self._waiters)):The except branch is unreachable. The preceding early return ensures
self._waitersis a non-emptycollections.dequeAfter:
No behavior change.