Skip to content

gh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.py #149345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skirpichev wants to merge 9 commits into
base: main
Choose a base branch
from
+5 −3
Open

gh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.py #149345

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d00c981
gh-146238: add missing tests for 'e' type code in test_buffer.py
skirpichev May 4, 2026
6d1251c
Merge branch 'master' into amend-e-format
skirpichev May 5, 2026
b4569cb
+ Zf/d
skirpichev May 5, 2026
2e1c01b
skip Zd in test_array_alignment()
skirpichev May 5, 2026
b97670b
fix test
skirpichev May 5, 2026
71ab6d1
+1
skirpichev May 5, 2026
7317fa0
address review
skirpichev May 6, 2026
e8b47ab
Merge branch 'master' into amend-e-format
skirpichev May 6, 2026
7886246
+1
skirpichev May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Lib/test/test_buffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def native_type_range(fmt):
# Format codes supported by array.array
ARRAY = NATIVE.copy()
for k in NATIVE:
if not k in "bBhHiIlLfd":
if k not in list("bBhHiIlLefd") + ['Zf', 'Zd']:
del ARRAY[k]
Comment thread
skirpichev marked this conversation as resolved.

BYTEFMT = NATIVE.copy()
Expand Down Expand Up @@ -4495,8 +4495,10 @@ def test_bytearray_alignment(self):
def test_array_alignment(self):
# gh-140557: pointer alignment of buffers including empty allocation
# should match the maximum array alignment.
align = max(struct.calcsize(fmt) for fmt in ARRAY)
cases = [array.array(fmt) for fmt in ARRAY]
formats = [fmt for fmt in ARRAY
if struct.calcsize(fmt) <= struct.calcsize('P')]
align = max(struct.calcsize(fmt) for fmt in formats)
cases = [array.array(fmt) for fmt in formats]
# Empty arrays
self.assertEqual(
[_testcapi.buffer_pointer_as_int(case) % align for case in cases],
Expand Down
Loading