gh-149342: _remote_debugging: Fix binary profile corruption when sampling a (temporarily) empty stack#149343
Merged
pablogsal merged 12 commits intopython:mainfrom May 5, 2026
Merged
Conversation
maurycy
commented
May 4, 2026
Documentation build overview
19 files changed ·
|
pablogsal
reviewed
May 4, 2026
maurycy
commented
May 4, 2026
``` Objects/descrobject.c:194:16: runtime error: call to function BinaryWriter_get_total_samples through pointer to incorrect function type 'struct _object *(*)(struct _object *, void *)' /home/maurycy/cpython/./Modules/_remote_debugging/module.c:1660: note: BinaryWriter_get_total_samples defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/descrobject.c:194:16 ``` https://github.com/python/cpython/actions/runs/25297636845/job/74159079502
pablogsal
force-pushed
the
remote-debugger-empty-stack-exc
branch
from
19586a0 to
913b5c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My understanding is that an empty stack is a bit racy but perfectly valid?
Closes #149342
_remote_debugging:Invalid RLE count XXX exceeds maximum possible XXX for remaining data#149342