Skip to content

Indexing is more straight-forward (and faster) than unpacking #145154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 1 commit into from
Feb 23, 2026
+4 −4
Merged

Indexing is more straight-forward (and faster) than unpacking #145154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Lib/heapq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ def nsmallest(n, iterable, key=None):
for elem in it:
if elem < top:
_heapreplace(result, (elem, order))
top, _order = result[0]
top = result[0][0]
order += 1
result.sort()
return [elem for (elem, order) in result]
Expand All @@ -529,7 +529,7 @@ def nsmallest(n, iterable, key=None):
k = key(elem)
if k < top:
_heapreplace(result, (k, order, elem))
top, _order, _elem = result[0]
top = result[0][0]
order += 1
result.sort()
return [elem for (k, order, elem) in result]
Expand Down Expand Up @@ -569,7 +569,7 @@ def nlargest(n, iterable, key=None):
for elem in it:
if top < elem:
_heapreplace(result, (elem, order))
top, _order = result[0]
top = result[0][0]
order -= 1
result.sort(reverse=True)
return [elem for (elem, order) in result]
Expand All @@ -587,7 +587,7 @@ def nlargest(n, iterable, key=None):
k = key(elem)
if top < k:
_heapreplace(result, (k, order, elem))
top, _order, _elem = result[0]
top = result[0][0]
order -= 1
result.sort(reverse=True)
return [elem for (k, order, elem) in result]
Expand Down
Loading