gh-145105: Fix crash in csv.reader with re-entrant iterator#145106
Open
raminfp wants to merge 1 commit intopython:mainfrom
Open
gh-145105: Fix crash in csv.reader with re-entrant iterator#145106raminfp wants to merge 1 commit intopython:mainfrom
raminfp wants to merge 1 commit intopython:mainfrom
Conversation
When a custom iterator calls next() on the same csv.reader from within __next__, the inner iteration sets self->fields to NULL. The outer iteration then crashes in parse_save_field() by passing NULL to PyList_Append. Add a guard after PyIter_Next() to detect that fields was set to NULL by a re-entrant call, and raise csv.Error instead of crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix adds a guard right after
PyIter_Nextreturns: ifself->fieldshas been set toNULLby a re-entrant call, raisecsv.Errorinstead of continuing intoparse_process_char._csv.reader: NULL deref via re-entrant iterator #145105