gh-145037: Fix Emscripten trampoline with emcc >= 4.0.19#145038
gh-145037: Fix Emscripten trampoline with emcc >= 4.0.19#145038hoodmane wants to merge 2 commits intopython:mainfrom
Conversation
0725f55 to
200d8fe
Compare
This undoes a change made as a part of PR 137470. We add an `emscripten_trampoline` field in `pycore_runtime_structs.h` and initialize it from JS initialization code with the wasm-gc based trampoline if possible. Otherwise we fall back to the JS trampoline.
200d8fe to
526e102
Compare
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 526e102 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145038%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
@hoodmane Not sure what is going on here, but this has broken the Emscripten buildbot. |
|
Looks like there are some mistakes to fix here. |
|
!buildbot emscripten I think it should be better now. |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit f3d03d3 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145038%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Okay now it is better. |
This undoes a change made as a part of #137470. We add an
emscripten_trampolinefield inpycore_runtime_structs.hand initialize it from JS initialization code with the wasm-gc based trampoline if possible. Otherwise we fall back to the JS trampoline.cc @freakboy3742 @ryanking13