gh-81218: Make macOS framework builds relocatable via @rpath#144305
gh-81218: Make macOS framework builds relocatable via @rpath#144305dmnq-f wants to merge 3 commits intopython:mainfrom
Conversation
dmnq-f
requested review from
a team,
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
CC @sethmlarson, the fuzzers are failing, and it doesn't seem related. |
macOS framework builds (--enable-framework) now produce relocatable frameworks. The installed framework can be moved to any location and will work without requiring install_name_tool rewriting by users. This uses install-time transformation: build-time behavior is unchanged (absolute install names), and install_name_tool transforms the installed binaries to use @rpath. Changes: - Add -headerpad_max_install_names to LINKFORSHARED and pythonw build - Transform dylib install name to @rpath at install time - Add LC_RPATH entries to installed binaries (bin/python3, Python.app) - Compute rpath depths dynamically via os.path.relpath() Signed-off-by: Dominique Fuchs <df@0x9d.net>
dmnq-f
force-pushed
the
gh-81218-relocatable-framework-rpath
branch
from
31893c4 to
3ac12f5
Compare
Yeah, just rebased to current main, and they still do (indeed though, it looks totally unrelated to me and seems to happen to the other few CI runs where fuzzer runs are active and not manually skipped, too). Update: Latest merge from current master doesn't show failing fuzzers anymore, it seems. |
|
This PR is stale because it has been open for 30 days with no activity. |
Good point, bot 👏🏻. @ned-deily I see you self-assigned this early on, but there has never been any comment on the actual PR content. Is this something to keep open or anything in it to align? |
Thanks for the PR and for your patience. I am reviewing it now and may have some comments later. |
3 participants
With these changes, macOS framework builds (--enable-framework) produce relocatable frameworks. The installed framework can be moved to any location and will work without requiring install_name_tool rewriting by users.
This uses install-time transformation: build-time behavior is unchanged (absolute install names), and install_name_tool transforms the installed binaries to use appropriate @rpath.
iOS target already uses
@rpathat build time because iOS builds are cross-compiled—there's no./python.exeexecution, no venvs, no shell script tests during development. macOS framework builds are different though and would break build-tree workflows because venv symlinks cause@executable_pathto resolve to the wrong directory, SIP stripsDYLD_FRAMEWORK_PATHfrom shell scripts, and so on.The install-time approach avoids all these issues, introducing no regression for build-tree workflows, follows existing patterns (CMake projects, Qt, ...) and makes the installed framework fully relocatable by default.
Changes
Related