Add command timeout#9
Open
jackeichen wants to merge 1 commit into
Open
Conversation
Author
|
@rosjat @Flameeyes @sahlberg Hi guys, here is the expected change in the code. Please check and give the feedback. This PR is related to python-scsi/python-scsi#149. Use a const value "DEFAULT_TIMEOUT", to help to get the default timeout by: |
rosjat
requested changes
May 15, 2026
| from libc.errno cimport errno | ||
| from libc.stdlib cimport calloc, free | ||
|
|
||
| DEFAULT_TIMEOUT = 1800000 |
Contributor
There was a problem hiding this comment.
this is unessesary, you can simply pass the value in the execute method this is the default if you dont provide a vaklue in the call.
timeout=1800000
Add command timeout(2nd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add command timeout