[typing] use less restrictive type hints for some public methodes#1547
[typing] use less restrictive type hints for some public methodes#1547neoniobium wants to merge 1 commit intopython-cmd2:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1547 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 21 21
Lines 4942 4942
=======================================
Hits 4890 4890
Misses 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for this suggestion. While I'm not ready to accept this exact change just yet, I do agree with its intentions. I have added this to our #1538 |
|
We revisited the intent of this PR in #1584 . Changes will be released in version 4.0.0. |
I when using cmd2, I found the type hints to be to restrictive since I like to use tuples and frozensets.
Hence ,I changed some list types to Iterable or Sequence depending if len seamed to be required.
No functional change intended.
Please review, and feel free to discard.