Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip incremental live rendering when output is non-interactive, while keeping the live manager lifecycle intact.
Concretely:
LiveExecutionandLiveCollectionwithrender_immediately=console.is_interactive_update_table()/ status refreshes when output is not interactiveMotivation
On non-interactive output, the incremental Rich redraws are not user-visible, but pytask still pays the formatting and refresh cost on every task event. This change keeps the same end result while avoiding that repeated work.
Validation
uv run --group test pytest tests/test_live.py tests/test_build.py tests/test_execute.py tests/test_collect.pyBenchmark
Synthetic workload: 300 tiny non-provisional tasks, each with 3 path dependencies and 2
Annotated[..., Product]outputs.On current
mainvs this branch:collect:0.915s->0.921s(+0.6%, noise)build --force:3.312s->2.893s(-12.7%)build:1.507s->1.462s(-3.0%)These runs were measured sequentially with
hyperfineover 7 runs.