hir-130: add GitHub Actions CI (typecheck + lint + test:int)#23
Open
jaredzwick wants to merge 1 commit intopypesdev:mainfrom
Open
hir-130: add GitHub Actions CI (typecheck + lint + test:int)#23jaredzwick wants to merge 1 commit intopypesdev:mainfrom
jaredzwick wants to merge 1 commit intopypesdev:mainfrom
Conversation
Open PRs to pypesdev/coldflow currently report no checks because the test suite only runs locally. Adds .github/workflows/ci.yml that runs on every pull_request and every push to main: - pnpm install --frozen-lockfile - pnpm exec tsc --noEmit (no typecheck script in package.json yet) - pnpm lint - pnpm test:int test:int boots Payload, so the workflow provisions a Postgres 16 service container and sets PAYLOAD_SECRET + DATABASE_URL_PAYLOAD for the run. Node + pnpm versions match the Dockerfile (node 22.17.0, pnpm 10). Vercel preview-deploy auth, e2e tests, and coverage gates are out of scope per HIR-130.
Collaborator
Author
|
First-run gate: GitHub treats this as the repo's first workflow file from a fork PR, so the run won't kick off until a To validate after merge, rebase one of the open HIR-94 PRs (#8, #13, #18, #19, #20, #21, #22) and confirm a green check appears. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.github/workflows/ci.ymlso PRs topypesdev/coldflowactually get tested before merge. Today the open HIR-94 PRs all show "no checks reported" —pnpm test:intonly runs on the engineer's local machine.The workflow runs on every
pull_requestand every push tomain:pnpm install --frozen-lockfilepnpm exec tsc --noEmit— there is notypecheckscript inpackage.jsonyet, so the issue'stsc --noEmitfallback is used directlypnpm lintpnpm test:inttest:intboots Payload, which refuses to start withoutPAYLOAD_SECRETand a Postgres connection. CI provisions apostgres:16-alpineservice container (matchesdocker-compose.yaml), creates thepayloaddatabase, and exportsDATABASE_URL_PAYLOAD+ a test-onlyPAYLOAD_SECRET. Node and pnpm versions match the Dockerfile: Node 22.17.0, pnpm 10 (nopackageManagerfield is pinned inpackage.json, so the workflow pins explicitly).README has a new
# CIsection documenting the four commands so contributors know what to expect locally.Once merged, all open HIR-94 PRs will start getting checks after a rebase. Per HIR-130: Vercel preview-deploy auth, E2E tests, and coverage gates are out of scope.
Test plan
pnpm install --frozen-lockfilesucceeds locally with pnpm 10.23.0pnpm exec tsc --noEmitpasses onorigin/mainpnpm lintpasses (warnings only) onorigin/maintest:intfiles pass without env; the 8th (api.int.spec.ts) needs Payload + Postgres, which CI now provides🤖 Generated with Claude Code