-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Remove dead link to pkg_resources #2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -157,10 +157,16 @@ the `native namespace package example project`_. | |||||
| Legacy namespace packages | ||||||
| ------------------------- | ||||||
|
|
||||||
| .. warning:: | ||||||
|
|
||||||
| The information in this section is obsolete and is no longer functional | ||||||
| (as of Setuptools 82.0.0). It is only retained for historical reference. | ||||||
|
|
||||||
| ``pkg_resources`` has been deprecated and was fully removed in Setuptools 82.0.0. | ||||||
|
|
||||||
| These two methods, that were used to create namespace packages prior to :pep:`420`, | ||||||
| are now considered to be obsolete and should not be used unless you need compatibility | ||||||
| with packages already using this method. Also, :doc:`pkg_resources <setuptools:pkg_resources>` | ||||||
| has been deprecated. | ||||||
| with packages already using this method. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| To migrate an existing package, all packages sharing the namespace must be migrated simultaneously. | ||||||
|
|
||||||
|
|
@@ -216,7 +222,7 @@ in the `pkgutil namespace example project`_. | |||||
| pkg_resources-style namespace packages | ||||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||||||
|
|
||||||
| :doc:`Setuptools <setuptools:index>` provides the `pkg_resources.declare_namespace`_ function and | ||||||
| :doc:`Setuptools <setuptools:index>` previously provided the ``pkg_resources.declare_namespace`` function and | ||||||
| the ``namespace_packages`` argument to :func:`~setuptools.setup`. Together | ||||||
| these can be used to declare namespace packages. While this approach is no | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| longer recommended, it is widely present in most existing namespace packages. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
@@ -285,7 +291,5 @@ to :func:`~setuptools.setup` in :file:`setup.py`. For example: | |||||
| A complete working example of two pkg_resources-style namespace packages can be found | ||||||
| in the `pkg_resources namespace example project`_. | ||||||
|
|
||||||
|
Comment on lines
291
to
293
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
We shouldn't link to an example that no longer works. |
||||||
| .. _pkg_resources.declare_namespace: | ||||||
| https://setuptools.readthedocs.io/en/latest/pkg_resources.html#namespace-package-support | ||||||
| .. _pkg_resources namespace example project: | ||||||
| https://github.com/pypa/sample-namespace-packages/tree/master/pkg_resources | ||||||
|
Comment on lines
294
to
295
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This warning is misplaced - it should be down in the
pkg_resourcessubsection.pkgutilbased legacy namespace packages have no connection to setuptools, they rely solely on the standard library (and we don't have any plans to break them that I'm aware of).