Fix numpy array syntax in scaling.py and update tests#2712
Open
r0hansaxena wants to merge 1 commit intopvlib:mainfrom
Open
Fix numpy array syntax in scaling.py and update tests#2712r0hansaxena wants to merge 1 commit intopvlib:mainfrom
r0hansaxena wants to merge 1 commit intopvlib:mainfrom
Conversation
8ea1c8b to
e99207d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scaling.pyNumpy function arg bug #2614docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num `. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Description
This PR addresses Issue #2614, where latlon_to_xy in pvlib/scaling.py was incorrectly handling discrete scaling factors due to a
numpysyntax error. Instead of passing a list tonp.array(), the code passed separate arguments, leading to incorrect coordinate scaling.Proposed Changes
np.arraycall to properly scale latitude and longitude by their respective factors.Verification Results
All tests in
tests/test_scaling.pynow pass locally with the corrected calculations.