Add is_backtracking and is_at_limit outputs to singleaxis#2709
Open
r0hansaxena wants to merge 1 commit intopvlib:mainfrom
Open
Add is_backtracking and is_at_limit outputs to singleaxis#2709r0hansaxena wants to merge 1 commit intopvlib:mainfrom
r0hansaxena wants to merge 1 commit intopvlib:mainfrom
Conversation
Add two boolean output columns to pvlib.tracking.singleaxis: - is_backtracking: True when tracker is in backtracking mode - is_at_limit: True when rotation angle is clipped to max/min Closes pvlib#2672
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Add two boolean output columns to pvlib.tracking.singleaxis:
As discussed in #2672, this implements the simpler suggestion of adding two boolean flags (is_backtracking and is_at_limit) indicating the physical state of the tracker, rather than a full enumerated state dictionary.
temp < 1when backtracking is enabled).tracker_thetato its unclipped ideal angle.Existing tests were updated to gracefully handle the extra columns without breaking, and two new tests were added specifically to cover the new boolean flags.